Sheep farm is broken (no raw wool)

[Quassy]

In my current game (compressed file attached) a farm is broken. There is an animation of the sheep that gets sheared but it never stops. The farm does not have any raw wool (i18n-de: "Lammwolle") and so it's not producing anything.

[totycro]

Acctually, this should not happen ;)

For both of the farms, one animal is in the stopped-state, which means it's waiting for the animalcollector (herder) to pick it up.

However both animalcollectors are in the state waiting_for_animal_to_stop, which means they haven't been notified by the animal, that it has already stopped. (The herder always waits for the animal to stop eating before it's collected. the animal is notified that the herder want's to collect it, and as soon as it has finished eating, it tells the herder that it's now ready to be collected; this action has not happened at both farms)

[totycro]

Replying to totycro: the code for that in animal.py:82f is this:

collector.pickup_animal()
self.state = self.states.stopped

and somehow, the second line got executed, but not the first one.

[totycro]

I just produced about 800t of wool, without any problems. Can someone reproduce this bug?

[wentam]

I've had a related issue: There is a sheep on top of the farm building and the sheep roaming around, however the farm is getting no wool for the weavers.

I'm attaching a savegame.

[rudis]

Hi. I have the same problem (no wool produced). And I get a crash when I remove the roaming.

Attached is a savegame to reproduce it, remove the left roaming and you should get a crash (created with 72d9973fb5ae790f508205bd21e5d4b2dd9f72be).

I get the following traceback:

 File "/home/simon/unknown-horizons/horizons/gui/mousetools/tearingtool.py", line 78, in mouseReleased
    None
 File "/home/simon/unknown-horizons/horizons/command/__init__.py", line 35, in execute
    None
 File "/home/simon/unknown-horizons/horizons/manager.py", line 55, in execute
    None
 File "/home/simon/unknown-horizons/horizons/command/building.py", line 168, in __call__
    None
 File "/home/simon/unknown-horizons/horizons/world/building/nature.py", line 61, in remove
    None
 File "/home/simon/unknown-horizons/horizons/world/resourcehandler.py", line 82, in remove
    None
 File "/home/simon/unknown-horizons/horizons/world/units/collectors/animalcollector.py", line 64, in cancel
    None
 File "/home/simon/unknown-horizons/horizons/world/units/animal.py", line 66, in remove_stop_after_job
    None
 AssertionError

Traceback (most recent call last):
  File "run_uh.py", line 405, in <module>
    main()
  File "run_uh.py", line 183, in main
    ret = horizons.main.start(options)
  File "/home/simon/unknown-horizons/horizons/main.py", line 153, in start
  File "/home/simon/unknown-horizons/horizons/engine.py", line 329, in run
  File "/home/simon/unknown-horizons/horizons/engine.py", line 337, in loop
  File "/home/simon/FIFE/engine/python/fife/fife.py", line 1777, in pump
RuntimeError: Catched director exception
AL lib: ALc.c:1302: exit() 1 device(s) and 1 context(s) NOT deleted